Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/backend/migrating image storage to azureblobs #342

Merged
merged 10 commits into from
Aug 24, 2024

Conversation

waveyboym
Copy link
Member

@waveyboym waveyboym commented Aug 24, 2024

Description

This pr proposes migration from storing images on mongodb database and storing as blobs on azure storage. The main benefits that this pr has introduced:

  1. Significantly improved loading times for all images(nearly 0.0 sec for all qualities)
  2. Significantly improved upload times (down from 7-10sec to 2-5sec)
  3. Significantly reduced overall codebase
  4. Eliminates need for caching images on ubuntu vm thereby introducing memory savings

Fixes # (issue)
#341

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Tested all updated endpoints using postman

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@waveyboym waveyboym added type: documentation Improvements or additions to documentation type: feature A new feature type: fix Introduces a fix for a previous issue type: testing This affects one or more tests For: api This is mainly for the api For: backend This is mainly for the backend code priority: high This needs/needed to be addressed as soon as possible effort: 5 This may require/required hours of work For: deployment This will affect our deployed system labels Aug 24, 2024
@waveyboym waveyboym added this to the Week 1 Sprint 4 milestone Aug 24, 2024
@waveyboym waveyboym self-assigned this Aug 24, 2024
@waveyboym waveyboym linked an issue Aug 24, 2024 that may be closed by this pull request
1 task
Copy link

codecov bot commented Aug 24, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 12 lines in your changes missing coverage. Please review.

Project coverage is 81.32%. Comparing base (396ec41) to head (03e1545).
Report is 11 commits behind head on develop.

Files Patch % Lines
occupi-backend/pkg/database/database.go 0.00% 12 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #342      +/-   ##
===========================================
- Coverage    81.39%   81.32%   -0.07%     
===========================================
  Files           53       10      -43     
  Lines         3294     1869    -1425     
  Branches        81        0      -81     
===========================================
- Hits          2681     1520    -1161     
+ Misses         522      307     -215     
+ Partials        91       42      -49     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@waveyboym waveyboym merged commit 6bafd23 into develop Aug 24, 2024
6 of 8 checks passed
@waveyboym waveyboym deleted the feat/backend/migrating-image-storage-to-azureblobs branch August 24, 2024 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort: 5 This may require/required hours of work For: api This is mainly for the api For: backend This is mainly for the backend code For: deployment This will affect our deployed system priority: high This needs/needed to be addressed as soon as possible type: documentation Improvements or additions to documentation type: feature A new feature type: fix Introduces a fix for a previous issue type: testing This affects one or more tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TASK] Migrate image storage from mongodb to azure blobs
1 participant