Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Profile/backend/profiling #291

Merged
merged 6 commits into from
Aug 10, 2024
Merged

Profile/backend/profiling #291

merged 6 commits into from
Aug 10, 2024

Conversation

waveyboym
Copy link
Member

@waveyboym waveyboym commented Aug 10, 2024

Description

Profiling updates. This pr introduces some much needed methods for monitoring and profiling the entire tech stack to quantify our quality requirements

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

N/A
Since this is mainly for monitoring, it doesn't make sense to test. Rather we shall observe data collected from running our tech stack

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@waveyboym waveyboym added type: security This is a security related issue/pr type: testing This affects one or more tests For: deployment This will affect our deployed system labels Aug 10, 2024
@waveyboym waveyboym added this to the Week 6 Sprint 3 FINAL!!! milestone Aug 10, 2024
@waveyboym waveyboym self-assigned this Aug 10, 2024
Copy link

gitguardian bot commented Aug 10, 2024

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
13149987 Triggered Generic Password f91393b frontend/occupi-mobile4/services/authservices.ts View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@waveyboym waveyboym merged commit 5a513fd into develop Aug 10, 2024
7 checks passed
@waveyboym waveyboym deleted the profile/backend/profiling branch August 10, 2024 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
For: deployment This will affect our deployed system type: security This is a security related issue/pr type: testing This affects one or more tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant