Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update .gitignore files and add coverage directory and some coverage collection logic #243

Merged
merged 4 commits into from
Jul 26, 2024

Conversation

waveyboym
Copy link
Member

@waveyboym waveyboym commented Jul 26, 2024

Description

Introducing some logic for code-coverage reports for the frontend

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Code cov was tested on all three platforms to ensure it performs as expected

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@waveyboym waveyboym added type: testing This affects one or more tests For: frontend This is mainly related to frontend UI code For: backend This is mainly for the backend code effort: 1 This can be/was resolved in minutes platform: mobile This is related to mobile platforms platform: web/desktop This is related to web/desktop platforms labels Jul 26, 2024
@waveyboym waveyboym self-assigned this Jul 26, 2024
Copy link

codecov bot commented Jul 26, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 63.23%. Comparing base (bed657d) to head (7fbeb1a).
Report is 79 commits behind head on develop.

Files Patch % Lines
occupi-backend/pkg/utils/utils.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #243      +/-   ##
===========================================
+ Coverage    59.60%   63.23%   +3.62%     
===========================================
  Files            8       20      +12     
  Lines         1634     1863     +229     
===========================================
+ Hits           974     1178     +204     
- Misses         622      647      +25     
  Partials        38       38              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@waveyboym waveyboym merged commit 2aac392 into develop Jul 26, 2024
9 of 11 checks passed
@waveyboym waveyboym deleted the chore/frontend/codecov-pain branch July 26, 2024 13:38
waveyboym added a commit that referenced this pull request Aug 12, 2024
chore: Update .gitignore files and add coverage directory and some coverage collection logic
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort: 1 This can be/was resolved in minutes For: backend This is mainly for the backend code For: frontend This is mainly related to frontend UI code platform: mobile This is related to mobile platforms platform: web/desktop This is related to web/desktop platforms type: testing This affects one or more tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant