Better error message in case of missing assets on the local Dev server

[TysonMN]

Consider this function

codedoc/src/serve/index.ts

Lines 41 to 63 in 5a74bb8

	app.get(`${config.dest.namespace}/*`, (req, res) => {
	const normalUrl = req.originalUrl.substr(config.dest.namespace.length).split('?')[0];
	const filename = (normalUrl === '/' ? 'index' : normalUrl) + '.html';
	const filepath = join(root, config.dest.html, filename);
	res.sendFile(filepath, {}, err => {
	if (err) {
	if (!built) {
	compile(buildingHtml)
	.serialize()
	.then(html => res.status(200).send(html));
	}
	else {
	console.log(chalk.red('# Not Found::'));
	console.log(chalk.red('# ') + req.originalUrl);
	console.log(chalk.red('# ') + chalk.gray(filepath));
	console.log();
	res.sendFile(join(root, config.dest.html, _dropExt(config.src.not_found) + '.html'), {}, err => {
	if (err) res.status(404).send('Not Found!!');
	});
	}
	}
	});
	});

but especially line 43

codedoc/src/serve/index.ts

Line 43 in 5a74bb8

const filename = (normalUrl === '/' ? 'index' : normalUrl) + '.html';

Is it correct that '.html' is always being appended to that file name?

I am playing around with the configuration and sometimes I get it wrong. Here is what one of the "Not Found::" error messages looks like for me.

# Not Found::
# /generated/bundle/codedoc-bundle.js
# C:\Code\Blogs\tyson-williams-blog\generated\generated\bundle\codedoc-bundle.js.html

On the topic of error messages, where are those beautiful colors? My error message doesn't have any red in it :(

[loreanvictor]

Yeah the error message could perhaps be improved, but appending .html is correct. Basically, if it was a static file it should have already been served by static middleware, so when we get to that line we are looking for an html file to serve.

P.S. what happened that you lost those colors? There is actually a good amount of work dedicated just to ensure that they would be visible!

[TysonMN]

How is it correct? The third line of the error message says it can't find a file called codedoc-bundle.js.html. Isn't it supposed to be looking for a file called codedoc-bundle.js?

[loreanvictor]

How is it correct? The third line of the error message says it can't find a file called codedoc-bundle.js.html. Isn't it supposed to be looking for a file called codedoc-bundle.js?

It does at first, but when it is unable to find it, it searches for the html file.

[TysonMN]

Oh, ok. I didn't realize that. I was confused.

The first path is relative and the second is absolute, so I thought the second path was intended to be the absolute version of what was actually checked for the first path. I thought that was a really good idea. How many time have we all had some file-not-found error and the path given in the error message was relative? Too many to count! I am not always sure where the corresponding absolute path would be. As a debugging technique, I create a file with a unique name (like tyson-testing) at the corresponding relative directory path and then find that file via a program called SearchEverything that will instantly find that file no matter where it is in my entire C:\ drive.

What if the first line of the error message said something like this?

Unable to find codedoc-bundle.js. None of the following paths exist.

I think this would help me realize that it originally looked for the file codedoc-bundle.js and then "became more desperate" by looking for the file codedoc-bundle.js.html.

Also, what about displaying absolute paths in both cases (i.e. displaying an absolute path for the first path instead of a relative path)?

[loreanvictor]

@bender2k14 thats a good idea. will re-open the issue and rename it accordingly.

[loreanvictor]

deployed via @codedoc/core@0.2.6