fix: token 스크립트 수정 #6
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -18,5 +18,6 @@ | |
| }, | ||
| "[css]": { | ||
| "editor.defaultFormatter": "esbenp.prettier-vscode" | ||
| }, | ||
| "css.lint.unknownAtRules": "ignore" | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,6 @@ | ||
| @import "tailwindcss"; | ||
| @import "tw-animate-css"; | ||
| @import "./tokens.css"; | ||
|
|
||
| @custom-variant dark (&:is(.dark *)); | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,63 +1,61 @@ | ||
| export default function Home() { | ||
| return ( | ||
| <div className="bg-surface-base flex min-h-screen items-center justify-center font-sans"> | ||
| <main className="flex min-h-screen w-full max-w-3xl flex-col items-center gap-8 px-8 py-12"> | ||
| {/* 토큰 테스트 섹션 */} | ||
| <div className="w-full space-y-8 rounded-lg border border-gray-200 bg-white p-8 shadow-sm"> | ||
| <h1 className="text-24-700 text-brand-black border-b pb-4"> | ||
| 🎨 Design Token Test | ||
| </h1> | ||
|
|
||
| {/* 1. Typography */} | ||
| <section className="space-y-4"> | ||
| <h2 className="text-20-600">1. Typography</h2> | ||
| <div className="space-y-2 rounded bg-gray-50 p-4"> | ||
| <p className="text-24-700">Display 24px (Bold 700)</p> | ||
| <p className="text-20-600">Title 20px (SemiBold 600)</p> | ||
| <p className="text-18-500">Body 18px (Medium 500)</p> | ||
| <p className="text-16-400">Body 16px (Regular 400)</p> | ||
| <p className="text-14-400 text-disabled"> | ||
| Caption 14px (Disabled Color) | ||
| </p> | ||
| </div> | ||
| </section> | ||
|
|
||
| {/* 2. Colors & Backgrounds */} | ||
| <section className="space-y-4"> | ||
| <h2 className="text-20-600">2. Colors & Backgrounds</h2> | ||
| <div className="grid grid-cols-2 gap-4"> | ||
| <div className="bg-brand-secondary-pink flex h-20 items-center justify-center rounded-lg text-white"> | ||
| Pink Secondary | ||
| </div> | ||
| <div className="bg-brand-primary-orange flex h-20 items-center justify-center rounded-lg text-white"> | ||
| Orange Primary | ||
| </div> | ||
| <div className="bg-surface-base border-light flex h-20 items-center justify-center rounded-lg border"> | ||
| Surface Base | ||
| </div> | ||
| <div className="bg-disabled text-disabled flex h-20 items-center justify-center rounded-lg"> | ||
| Disabled Area | ||
| </div> | ||
| </div> | ||
| </section> | ||
|
|
||
| {/* 3. Buttons */} | ||
| <section className="space-y-4"> | ||
| <h2 className="text-20-600">3. Buttons</h2> | ||
| <div className="flex flex-wrap gap-4"> | ||
| <button className="btn-primary text-16-600 px-8 py-3 transition-opacity hover:opacity-90"> | ||
| Primary Button | ||
| </button> | ||
| <button className="btn-slate text-brand-black border-light text-16-600 rounded-2xl border px-8 py-3"> | ||
| Secondary Button | ||
| </button> | ||
| <button className="btn-disabled text-16-400 cursor-not-allowed px-8 py-3"> | ||
| Disabled Button | ||
| </button> | ||
| </div> | ||
|
Comment on lines
+47
to
+57
Contributor
There was a problem hiding this comment. 버튼 스타일링 문제 (버그 및 불일치)버튼 컴포넌트에서 두 가지 주요 문제가 발견되었습니다.
제안: 또한, 클래스 이름이 길어지고 있으므로, 코드 스타일 가이드라인(51번)에 따라 // cva를 사용하지 않는 경우의 수정 예시
<button className="bg-button-primary text-white rounded-2xl text-16-600 px-8 py-3 transition-opacity hover:opacity-90">
Primary Button
</button>References
|
||
| </section> | ||
| </div> | ||
| </main> | ||
| </div> | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
토큰화되지 않은 클래스 사용
디자인 토큰 시스템을 도입했음에도 불구하고,
border-gray-200,bg-white와 같이 토큰 시스템에 정의되지 않은 Tailwind 기본 클래스를 직접 사용하고 있습니다. 이는 디자인 시스템의 일관성을 해치고, 향후 테마(예: 다크 모드) 적용을 어렵게 만듭니다.제안:
tokens.css에 정의된 유틸리티 클래스를 사용하도록 수정해주세요.border-gray-200대신border-light사용을 고려해보세요.bg-white대신bg-surface-base또는 카드 배경을 위한 새로운 토큰 기반 클래스 사용을 고려해보세요. (token.json의theme.card.background에 해당하는 유틸리티가 필요해 보입니다.)bg-gray-50(14번 줄) 등 다른 곳에서도 동일한 문제가 발견되니 함께 검토해주세요.