Add comprehensive authentication tests #171
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add login failure scenario tests to UsersApiTest: - Test login with non-existent email - Test login with empty email/password - Test login with missing email/password fields - Add authentication tests to ArticlesApiTest: - Test creating article without token (401) - Test creating article with invalid token (401) - Add authentication tests to ArticleApiTest: - Test updating article without token (401) - Test updating article with invalid token (401) - Test deleting article without token (401) - Test deleting article with invalid token (401) - Add authentication tests to CommentsApiTest: - Test creating comment without token (401) - Test creating comment with invalid token (401) - Test deleting comment without token (401) - Test deleting comment with invalid token (401) - Add authentication tests to ArticleFavoriteApiTest: - Test favoriting article without token (401) - Test favoriting article with invalid token (401) - Test unfavoriting article without token (401) - Test unfavoriting article with invalid token (401) - Add authentication tests to ProfileApiTest: - Test following user without token (401) - Test following user with invalid token (401) - Test unfollowing user without token (401) - Test unfollowing user with invalid token (401) - Add token validation edge case tests to CurrentUserApiTest: - Test empty token string (401) - Test authorization header without space (401) - Test token referring to non-existent user (401) Co-Authored-By: Roshan Fernando <roshan.fernando@cognition.ai>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR expands authentication test coverage across the API layer by adding 26 new test cases that verify proper 401 responses for missing/invalid tokens and login failure scenarios.
Changes by file:
All 94 tests pass locally. The CI build failure is due to a pre-existing issue with deprecated
actions/cache: v2in the GitHub Actions workflow, unrelated to these changes.Review & Testing Checklist for Human
./gradlew test -x spotlessJavalocally to verify all tests passRecommended test plan: Run the full test suite locally and verify the 26 new tests are included in the test count (should be 94 total tests).
Notes
actions/cache: v2which GitHub has disabled