Skip to content

Conversation

@devin-ai-integration
Copy link

@devin-ai-integration devin-ai-integration bot commented Dec 2, 2025

Summary

This PR improves the Java 11 build configuration by adding proper Gradle toolchain support and modernizing the CI workflow. The project was already targeting Java 11 but lacked explicit toolchain configuration and had outdated CI action versions.

Build changes:

  • Added Java toolchain configuration in build.gradle (replaces sourceCompatibility/targetCompatibility)
  • Upgraded Gradle wrapper from 7.4 to 7.6.4
  • Upgraded Spotless plugin from 6.2.1 to 6.25.0 (required for Java 11+ module system compatibility)
  • Added UTF-8 encoding for Java compilation

CI changes:

  • Updated GitHub Actions to v4 (checkout, setup-java)
  • Changed JDK distribution from Zulu to Temurin
  • Simplified caching using setup-java's built-in Gradle cache support

Review & Testing Checklist for Human

  • Verify CI passes with the updated workflow and Gradle configuration
  • Confirm the Spotless plugin upgrade (6.2.1 → 6.25.0) doesn't introduce unexpected formatting changes beyond the one file modified (DefaultJwtServiceTest.java)
  • Validate that the toolchain configuration produces Java 11 bytecode (can check with javap -v on a compiled class)

Recommended test plan: After CI passes, pull the branch locally and run ./gradlew clean build test to verify the build works end-to-end.

Notes

The codebase was analyzed for usage of removed JDK modules (JAXB, JAX-WS, JavaFX, CORBA, Nashorn) - none were found, so no additional dependencies were needed.

See MIGRATION_NOTES.md for detailed documentation of all changes.

Link to Devin run: https://app.devin.ai/sessions/22a134aac3e944e9a8ca4a321fa2f16f
Requested by: milind@cognition.ai (@milind-cognition)

devin-ai-integration bot and others added 4 commits December 2, 2025 07:27
… and spotless to 6.25.0

Co-Authored-By: milind@cognition.ai <milind@cognition.ai>
Co-Authored-By: milind@cognition.ai <milind@cognition.ai>
Co-Authored-By: milind@cognition.ai <milind@cognition.ai>
Co-Authored-By: milind@cognition.ai <milind@cognition.ai>
@devin-ai-integration
Copy link
Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant