Phase 1: Initialize React Project Infrastructure for Angular to React Migration #84
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… migration - Created new React + TypeScript project with Vite inside angular2-hn repo - Installed and configured React Router with all Angular routes: * Feed routes: /news/:page, /newest/:page, /show/:page, /ask/:page, /jobs/:page * Item details: /item/:id * User profile: /user/:id - Implemented Settings Context API for state management: * Theme management (default/night) with system preference detection * localStorage persistence for all settings (theme, openLinkInNewTab, titleFontSize, listSpacing) * System dark mode preference detection using window.matchMedia - Created placeholder page components (Feed, ItemDetails, User) - Fixed lint error in pre-installed use-toast.ts hook - Tested locally: app runs, routing works, theme switching functional This establishes the foundation for migrating the Angular Hacker News client to React. Co-Authored-By: Gabe Smith <gabriel.smith@cognition.ai>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Phase 1: Initialize React Project Infrastructure for Angular to React Migration
Summary
This PR establishes the foundational infrastructure for migrating the Angular 9 Hacker News client to React. It creates a new React + TypeScript application using Vite, configures routing to match all existing Angular routes, and implements state management for application settings with theme support.
Key Changes:
/react-appsubdirectory using Viteuse-toast.tslint error)What's NOT included (by design):
Review & Testing Checklist for Human
This is infrastructure setup with moderate risk. Please verify:
/news/1,/newest/1,/show/1,/ask/1,/jobs/1,/item/123,/user/testuserand verify each route renders correctlytheme,openLinkInNewTab,titleFontSize,listSpacingare being savedreact-app/package.json- large dependency list from shadcn/ui scaffold. Consider if all components will be neededNotes
App.tsx,SettingsContext.tsx,settings.ts, and the 3 page components.SettingsContext.tsxhas a React Hooks exhaustive-deps warning (not an error). This is acceptable for Phase 1 but worth noting.src/hooks/use-toast.tsby converting const to type definition.Link to Devin run: https://app.devin.ai/sessions/d83e0f9ca9c44669a5a976f8e0ce006e
Requested by: Gabe Smith (gabriel.smith@cognition.ai)