Fix Maven compiler plugin configuration for Java 17 (EB-3) #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove explicit version 3.8.0 to use Spring Boot managed version - Replace source/target 1.8 with release 17 configuration - Aligns compiler configuration with java.version property - Enables proper Java 17 compilation and language features JIRA: EB-3 Co-Authored-By: Alex Peng <alexander.j.peng@gmail.com>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA Ticket
EB-3: Fix Maven compiler plugin configuration for Java 17 in COG-GTM/Springboot-BankApp
Overview
This PR fixes a Java version mismatch in the Maven compiler plugin configuration. The project's
java.versionproperty was correctly set to 17, but the Maven compiler plugin was still configured for Java 1.8, creating build configuration inconsistencies.Changes Made
<version>3.8.0</version>to leverage Spring Boot's dependency management (now uses 3.13.0)<source>1.8</source>and<target>1.8</target>with<release>17</release><release>element which is the recommended approach for Java 9+ projectsRationale
The
<release>configuration element provides better compatibility than separate source/target settings because it:Verification
Build succeeds with the new configuration:
The compiler now correctly uses Java 17 for both source and target, matching the project's runtime environment (OpenJDK 17 in Docker) and Spring Boot 3.3.3 requirements.
Context
Link to Devin run: https://app.devin.ai/sessions/a9449a0118cf4a8399ff9c577cfa032b
Requested by: Alex Peng (alex.peng@windsurf.com) (@alexjpeng)