Fine tune constructor types

CODIQ-BV · Jun 17, 2019 · daa0601 · daa0601
1 parent 9b04ae9
commit daa0601
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/RedirectResponse.php b/RedirectResponse.php
@@ -32,7 +32,7 @@ class RedirectResponse extends Response
      *
      * @see http://tools.ietf.org/html/rfc2616#section-10.3
      */
-    public function __construct(?string $url, int $status = 302, array $headers = [])
+    public function __construct(string $url, int $status = 302, array $headers = [])
     {
         parent::__construct('', $status, $headers);
 
@@ -82,7 +82,7 @@ public function getTargetUrl()
      */
     public function setTargetUrl($url)
     {
-        if (empty($url)) {
+        if ('' == $url) {
             throw new \InvalidArgumentException('Cannot redirect to an empty URL.');
         }
 

diff --git a/Tests/RedirectResponseTest.php b/Tests/RedirectResponseTest.php
@@ -28,10 +28,11 @@ public function testGenerateMetaRedirect()
 
     /**
      * @expectedException \InvalidArgumentException
+     * @expectedExceptionMessage Cannot redirect to an empty URL.
      */
-    public function testRedirectResponseConstructorNullUrl()
+    public function testRedirectResponseConstructorEmptyUrl()
     {
-        $response = new RedirectResponse(null);
+        $response = new RedirectResponse('');
     }
 
     /**