-
Notifications
You must be signed in to change notification settings - Fork 3
Feature/metadata improvements #23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Thomas-Z
wants to merge
10
commits into
develop
Choose a base branch
from
feature/metadata_improvements
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a. Refactoring and cleaning.
Adding tests Refactoring and cleaning.
Making collection only containing immutable variables readable. Making view readable even if they do not have any declared variable (just reading the reference). Consolidating tests and refactoring.
Adding tests related to immutable variables presence in the dataset provided to update and map methods. Fixing drop_partitions tests (with timedelta)
Normalizing zcol/zview naming in tests.
…ate() methods. Adding the "filler" variable concept to differentiate variables added by the system and the one added by the user during insertion. Fixing partition order output of _normalize_partitions Removing "over typing".
… the default value of delayed (False if distributed is False, True otherwise).
…ng value of the group.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes are related to the addition of dimension information in the zcollection metadata.
The motivations behind these changes are as follows:
Prevent the creation of unreadable zcollections when adding a new partition with dimensions different from the original one.
Improve validation of inserted data.
Clean up some code that templated existing variables to obtain dimension sizes.
Enable new features made possible by this additional metadata.
These changes will require existing collections to be updated before new data can be written.
The following elements are implemented in this initial commit:
Collection.add_dimension
methodupdate_deprecated_collection
functionThe following tasks remain to be done:
Collection.add_dimension