Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compilation for OpenCV 4 #1439

Closed

Conversation

adujardin
Copy link

Using OpenCV 4 and Ubuntu (18.04) on default settings, the compilation fail with :

examples/tests/resizeTest.cpp:82:64: error: ‘CV_LOAD_IMAGE_GRAYSCALE’ was not declared in this scope
             op::Matrix opImg = op::loadImage(FLAGS_image_path, CV_LOAD_IMAGE_GRAYSCALE);

This simple fix replace the legacy OpenCV C API by the C++ one.

@stale
Copy link

stale bot commented Jan 26, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale/old label Jan 26, 2020
@stale stale bot closed this Feb 2, 2020
@peasant98
Copy link

I also had the same issue

gineshidalgo99 added a commit that referenced this pull request Apr 4, 2020
@gineshidalgo99 gineshidalgo99 added fixed/added in newer versions invalid - unrelated to OpenPose This doesn't seem right or is out of the OpenPose scope and removed stale/old labels Apr 4, 2020
@gineshidalgo99
Copy link
Member

Thanks! But unfortunately, I can't accept it because it would break 2.X compatibility (lots of people still using that OpenCV as well). Instead, I've just pushed an equivalent fix that doesn't break compatibility with the old 2.X version. Thanks for the catch!!

@gineshidalgo99 gineshidalgo99 added invalid - unrelated to OpenPose This doesn't seem right or is out of the OpenPose scope and removed invalid - unrelated to OpenPose This doesn't seem right or is out of the OpenPose scope labels Apr 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fixed/added in newer versions invalid - unrelated to OpenPose This doesn't seem right or is out of the OpenPose scope
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants