jimfuqian/BB2-3280-C4DIC POC: Enrich c4dic coverage w supporting image#1241
Merged
JFU-NAVA-PBC merged 5 commits intofeature/c4dicfrom Sep 9, 2024
Conversation
jimmyfagan
approved these changes
Sep 4, 2024
Contributor
jimmyfagan
left a comment
jimmyfagan
left a comment
There was a problem hiding this comment.
This looks good, I know there may be more changes here given what we talked about to get the _profile to work, but feel free to deliver this and make adjustments in a separate PR or add to this PR and re-request review, whatever works best!
apps/fhir/bluebutton/views/search.py
Outdated
| "url": "image", | ||
| "valueAttachment": { | ||
| "contentType": "image/png", | ||
| "data": "<replace with base64 encoded iamge png here>" |
Contributor
There was a problem hiding this comment.
Suggested change
| "data": "<replace with base64 encoded iamge png here>" | |
| "data": "<replace with base64 encoded image png here>" |
JFU-NAVA-PBC
deleted the
jimfuqian/BB2-3280-C4DIC-POC-Coverage-c4dic-supportingImage-ext-by-enrichment
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA Ticket:
BB2-3280
What Does This PR Do?
Enrich C4DIC Coverage with SupportingImage for POC purpose.
What Should Reviewers Watch For?
The supporting image provisioned can be viewed (rendered) by FE PR FE
If you're reviewing this PR, please check for these things in particular:
Validation
What Security Implications Does This PR Have?
Please indicate if this PR does any of the following:
security engineer's approval.
Any Migrations?
etc)