Skip to content

Feature/c4dic edits/jimmy/bb2 3257 adjust hardcoded endpoints#1212

Merged
jimmyfagan merged 7 commits intofeature/c4dicfrom
feature/c4dic-edits/jimmy/bb2-3257-adjust-hardcoded-endpoints
Jul 3, 2024
Merged

Feature/c4dic edits/jimmy/bb2 3257 adjust hardcoded endpoints#1212
jimmyfagan merged 7 commits intofeature/c4dicfrom
feature/c4dic-edits/jimmy/bb2-3257-adjust-hardcoded-endpoints

Conversation

@jimmyfagan
Copy link
Contributor

@jimmyfagan jimmyfagan commented Jun 27, 2024

JIRA Ticket:
BB2-3257

User Story or Bug Summary:
Updates to C4DIC feature branch.

What Does This PR Do?

  • Removes Organization endpoint
  • Stops requiring profile param to return hardcoded Patient resource
  • Edits sample json files for C4DIC

What Should Reviewers Watch For?

Nothing in particular. Feel free to test in Postman to verify that the new resources are returned.

What Security Implications Does This PR Have?

Submitters should complete the following questionnaire:

  • If the answer to any of the questions below is Yes, then here's a link to the associated Security Impact Assessment (SIA), security checklist, or other similar document in Confluence: N/A.
    • Does this PR add any new software dependencies? Yes or No.
    • Does this PR modify or invalidate any of our security controls? Yes or No.
    • Does this PR store or transmit data that was not stored or transmitted before? Yes or No.
  • If the answer to any of the questions below is Yes, then please add a Security Engineer and ISSO as a reviewer, and note that this PR should not be merged unless/until he also approves it.
    • Do you think this PR requires additional review of its security implications for other reasons? Yes or No.

What Needs to Be Merged and Deployed Before this PR?

This PR cannot be either merged or deployed until the following pre-requisite changes have been fully deployed:

  • CMSgov/some_repo#42

Any Migrations?

  • No migrations

Submitter Checklist

I have gone through and verified that...:

  • This PR is reasonably limited in scope, to help ensure that:
    1. It doesn't unnecessarily tie a bunch of disparate features, fixes, refactorings, etc. together.
    2. There isn't too much of a burden on reviewers.
    3. Any problems it causes have a small "blast radius".
    4. It'll be easier to rollback if that becomes necessary.
  • I have named this PR and its branch such that they'll be automatically be linked to the (most) relevant Jira issue, per: https://confluence.atlassian.com/adminjiracloud/integrating-with-development-tools-776636216.html.
  • This PR includes any required documentation changes, including README updates and changelog / release notes entries.
  • All new and modified code is appropriately commented, such that the what and why of its design would be reasonably clear to engineers, preferably ones unfamiliar with the project.
  • All tech debt and/or shortcomings introduced by this PR are detailed in TODO and/or FIXME comments, which include a JIRA ticket ID for any items that require urgent attention.
  • Reviews are requested from both:
    • At least two other engineers on this project, at least one of whom is a senior engineer or owns the relevant component(s) here.
    • Any relevant engineers on other projects (e.g. BFD, SLS, etc.).
  • Any deviations from the other policies in the DASG Engineering Standards are specifically called out in this PR, above.
    • Please review the standards every few months to ensure you're familiar with them.

@jimmyfagan jimmyfagan changed the base branch from master to feature/c4dic June 27, 2024 19:48
@jimmyfagan jimmyfagan marked this pull request as ready for review June 27, 2024 21:27
@jimmyfagan jimmyfagan requested a review from loganbertram June 27, 2024 21:27
Copy link
Contributor

@loganbertram loganbertram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Obviously not up on the details, and there's a minor test failure that needs sorted out, but this is good to merge as soon as that test is passing!

@jimmyfagan jimmyfagan merged commit 7fd44e3 into feature/c4dic Jul 3, 2024
@jimmyfagan jimmyfagan deleted the feature/c4dic-edits/jimmy/bb2-3257-adjust-hardcoded-endpoints branch July 3, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments