Merged
Conversation
…sample-client-python-react into feature/c4dic-jimmy-bb2-3391
noor1027
approved these changes
Oct 15, 2024
noor1027
left a comment
noor1027
left a comment
There was a problem hiding this comment.
I ran locally and verified.
Looking Good To Me
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA Ticket:
BB2-3459
What Does This PR Do?
This PR:
What Should Reviewers Watch For?
If you're reviewing this PR, please check that things look sensible at least for now for a POC.
Validation
Run a local web-server from the c4dic feature branch. Lookup your local IP, and update docker-compose.yml with your IP in
HOST_IP, then rundocker-compose up --buildfrom this branch. Authorize (BBUser02864 has start dates, the others likely do not) and view the insurance card. You should see something like: