Conversation
added 5 commits
November 21, 2022 21:30
make CI pass to clear for PR
dtisza1
suggested changes
Dec 2, 2022
README.md
Outdated
Contributor
There was a problem hiding this comment.
Suggested change
| cp server/sample-bluebutton-config.json -> server/.bluebutton-config.json | |
| cp server/sample-bluebutton-config.json server/.bluebutton-config.json |
Suggested change so that a copy & paste to the command line works.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA Ticket:
BB2-1701
User Story or Bug Summary:
Description:
With the Blue Button API app SDK (Node JS) going to be published, it is highly desirable that BB2 Python Sample App be re-factored to use the SDK, which will greatly reduce the impl work of a BB2 API app and a great demo if the value of SDK.
AC:
BB2 Node JS Sample App code base refactored to use BB2 Node Js SDK
What Does This PR Do?
Refactor BB2 Node JS React Sample App code to use BB2 Node JS SDK for OAUTH2 Flow and FHIR Data Flow processing.
Note, the client component (the react front end) remain the same.
the server component code now only has index.ts (dozens lines of code only focus on application business logic) - a demonstration that the SDK greatly simplified the app development.
Removed unit tests - with the complex logic under the SDK, unit tests are not needed here any more, instead end to end tests (such as selenium tests - front end and back end involved) are more suitable guard the sample app from broken or regression
What Should Reviewers Watch For?
delete images and cleanup dangling:
docker image ls | awk '{ print $3}' | grep -v "IMAGE" | xargs docker image rm -f
docker volume rm $(docker volume ls -qf dangling=true)
total wipe out
docker system prune -a --volumes
If you're reviewing this PR, please check these things, in particular:
Notes:
instead end to end testing - selenium tests added to cover the main scenarios