Rotate LAT wafers differently depending on type #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LAT wafers start at different zero points of rotation depending on whether they are hex packed or rhombihex. This change applies different rotations in those two cases so that the final wafer orientations are aligned.
|
Plots showing current master branch (left panel) and this PR branch (right panel) can be found here. You can see that the LAT HF wafers remain correct and the LAT MF/LF wafers are fixed. The SAT wafers are unaffected. Closes #31 |
smsimon
approved these changes
Sep 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LAT wafers start at different zero points of rotation depending on whether they are hex packed or rhombihex. This change applies different rotations in those two cases so that the final wafer orientations are aligned.