Fixed the cmake compile options to not override parent project #238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phbasler
pushed a commit
to phbasler/BSMPT
that referenced
this pull request
May 25, 2022
guikos11
pushed a commit
to guikos11/BSMPT
that referenced
this pull request
Jul 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@beniz @nikohansen
In phbasler/BSMPT#72 we noticed some issues with including cmaes as a submodule in a larger CMake project.
The old way to set CMAKE_CXX_FLAGS(_DEBUG/_RELEASE) overwrote the flags set by the parent project, which in our case led to a runtime crash.
After adjusting it locally to the proposed change, it works as expected.