Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update the range error output #690

Merged
merged 5 commits into from
Jan 5, 2022
Merged

Conversation

phlptp
Copy link
Collaborator

@phlptp phlptp commented Dec 13, 2021

to be able to be used by more types, and better printouts in some situations.

the driver for this was getting something like this as an error.

not in range 0.000000 to 179769313486231570814527423731704356798070567525844996598917476803157260780028538760589558632766878171540458953514382464234321326889464182768467546703537516986049910576551282076245490090389328944075868508455133942304583236903222948165808559332123348274797826204144723168738177180919299881250404026184124858368.000000

which is descriptive but kind of ridiculous.

and using std::to_string in a generic template is also potentially problematic is used for some unusual types.

@henryiii henryiii merged commit 5ba6362 into CLIUtils:main Jan 5, 2022
@henryiii henryiii deleted the range_error_output branch January 5, 2022 20:36
@github-actions github-actions bot added needs changelog Hasn't been added to the changelog yet needs README Needs to be mentioned in the README labels Jan 5, 2022
@henryiii henryiii removed needs changelog Hasn't been added to the changelog yet needs README Needs to be mentioned in the README labels Mar 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants