fix and test some reported issues #661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Oct 25, 2021
henryiii
approved these changes
Nov 2, 2021
github-actions
bot
added
needs changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will add a test for #550 (no fixes required)
and a test and fix for #549.
It adds an additional check and related error message for partially supplied types if the type size is a single number and greater than 1.
There is still an edge case where a vector of type with a range say 4 or 5 could be supplied with 6 arguments and would not generate an error. Catching that is somewhat more complicated and I am not entirely sure it is worth the check as in that circumstance would probably be better and clearer to change the expected to 1 and only allow one block per option specification.