Writing argument description to config string (issue #65) #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henryiii
reviewed
Dec 19, 2017
include/CLI/App.hpp
Outdated
| } | ||
|
|
||
| if (value.size() != 0) { | ||
| if (write_description and opt->description_.size() != 0) { |
There was a problem hiding this comment.
and is not valid here, should be && (Only msvc cares)
There was a problem hiding this comment.
This has now been changed.
Codecov Report
@@ Coverage Diff @@
## master #66 +/- ##
======================================
Coverage 100% 100%
======================================
Files 9 9
Lines 1345 1360 +15
Branches 251 0 -251
======================================
+ Hits 1345 1360 +15
Continue to review full report at Codecov.
|
…sue_65 # Conflicts: # include/CLI/App.hpp
|
When you remove the WIP I'll merge, LGTM. |
henryiii
changed the title
|
Ah, sorry. Forgot about that as I have been taking time off the past week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.