Support for Atomic types in flags and options #520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phlptp
force-pushed
the
atomic_type_support
branch
16 times, most recently
from
198eb01
to
e4a895f
Compare
Codecov Report
@@ Coverage Diff @@
## master #520 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 12 12
Lines 3740 3758 +18
=========================================
+ Hits 3740 3758 +18
Continue to review full report at Codecov.
|
phlptp
force-pushed
the
atomic_type_support
branch
8 times, most recently
from
a91dc1f
to
04dbdad
Compare
phlptp
force-pushed
the
atomic_type_support
branch
from
04dbdad
to
2dcbf15
Compare
phlptp
force-pushed
the
atomic_type_support
branch
from
2dcbf15
to
d68819f
Compare
henryiii
approved these changes
Oct 28, 2020
|
Thanks! |
henryiii
added
needs changelog
henryiii
removed
needs README
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #496
dealing with atomic types is kind of a pain.
This PR add support for them. And add the tests for them as well.
The main issue is that atomic types don't support direct assignment only assignment of the underlying type so there was a need to distinguish between the two type in a couple different locations that utilize the wrapper type.