Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support groups for subcommands. #46

Merged
merged 1 commit into from
Nov 20, 2017

Conversation

lambdafu
Copy link
Contributor

I like myself some groups for subcommands :). If you look at "git --help", for example, that obviously looks better than "svn --help". I chose to not order them alphabetically, but in insertion order. I think that this would also be better for option groups (instead of ordering them alphabetically), but this pull request does not change that.

@lambdafu
Copy link
Contributor Author

By the way, this also allows one to override the hard-coded "Subcommands" string. I am slowly eating away at those hard-coded untranslatable strings as a side-effect :)

@codecov
Copy link

codecov bot commented Nov 20, 2017

Codecov Report

Merging #46 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #46   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           9      9           
  Lines        1171   1182   +11     
  Branches      240    243    +3     
=====================================
+ Hits         1171   1182   +11
Impacted Files Coverage Δ
include/CLI/App.hpp 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79cd791...db20f91. Read the comment docs.

@henryiii
Copy link
Collaborator

This is very cool! It also works really well for my planned work on the inheritance of values. I'll open an issue describing my plans in a minute.

@henryiii henryiii merged commit 642a670 into CLIUtils:master Nov 20, 2017
@lambdafu lambdafu deleted the lambdafu/subcommandgroups branch November 20, 2017 17:50
@henryiii henryiii added this to the v1.3 milestone Nov 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants