Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config short #443

Merged
merged 9 commits into from
Mar 22, 2020
Merged

Config short #443

merged 9 commits into from
Mar 22, 2020

Conversation

phlptp
Copy link
Collaborator

@phlptp phlptp commented Mar 10, 2020

If merged this PR will allow short only and positional only options to be configurable and output to config files.
The order of preference for output is
first long option, first short option, positional, any form is used on input.

Closes #440

@codecov
Copy link

codecov bot commented Mar 10, 2020

Codecov Report

Merging #443 into master will not change coverage by %.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #443   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           12        12           
  Lines         3583      3602   +19     
=========================================
+ Hits          3583      3602   +19     
Impacted Files Coverage Δ
include/CLI/App.hpp 100.00% <100.00%> (ø)
include/CLI/Config.hpp 100.00% <100.00%> (ø)
include/CLI/Option.hpp 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 967bfe0...88cdf65. Read the comment docs.

@phlptp phlptp changed the title [WIP] Config short Config short Mar 11, 2020
@phlptp phlptp requested a review from henryiii March 15, 2020 01:28
@henryiii henryiii added this to the v2.0 milestone Mar 22, 2020
@henryiii henryiii merged commit f346f29 into CLIUtils:master Mar 22, 2020
@henryiii henryiii deleted the config_short branch March 22, 2020 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

config file issues
2 participants