Skip to content

Add and fix cpplint whitespace/comments #434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

cbachhuber
Copy link
Collaborator

Finalizing the work started in #400 (and part of #378): this PR enables the cpplint check whitespace/comments and fixes corresponding issues.

Also, it aligns the clang-format style to 2 spaces between code and trailing comments.

@codecov
Copy link

codecov bot commented Feb 17, 2020

Codecov Report

Merging #434 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #434   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          12     12           
  Lines        3582   3582           
=====================================
  Hits         3582   3582
Impacted Files Coverage Δ
include/CLI/Config.hpp 100% <ø> (ø) ⬆️
include/CLI/Split.hpp 100% <ø> (ø) ⬆️
include/CLI/Error.hpp 100% <ø> (ø) ⬆️
include/CLI/Timer.hpp 100% <ø> (ø) ⬆️
include/CLI/ConfigFwd.hpp 100% <ø> (ø) ⬆️
include/CLI/Option.hpp 100% <100%> (ø) ⬆️
include/CLI/Formatter.hpp 100% <100%> (ø) ⬆️
include/CLI/App.hpp 100% <100%> (ø) ⬆️
include/CLI/StringTools.hpp 100% <100%> (ø) ⬆️
include/CLI/TypeTools.hpp 100% <100%> (ø) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80d8e94...d8c146a. Read the comment docs.

@cbachhuber
Copy link
Collaborator Author

clang-format now requires test code also in proper formatting. Should we add folder tests to cpplint checks? I just checked, with the current cpplint configuration, there are 23 legal/copyright issues in tests, and 11 other issues.

@phlptp
Copy link
Collaborator

phlptp commented Feb 17, 2020

In general I think it is a good idea to treat the test code the same as the library code, so I would be in favor of running any checks on the test code. With the knowledge that I am pretty sure there are a few cases where we are purposely doing something Abnormal for the purpose of testing some aspect of the library, so there will likely be a few places where we have bypass the checks.

@phlptp
Copy link
Collaborator

phlptp commented Feb 17, 2020

I would enable the test checks in a separate PR though.

@henryiii
Copy link
Collaborator

I second that. Tests and (usually) examples should be included in checks. Second PR is best.

@cbachhuber
Copy link
Collaborator Author

Got it, I'll create a separate PR for including tests in cpplint and fixing the corresponding issues 👍

@henryiii henryiii merged commit d8a5bdc into CLIUtils:master Mar 6, 2020
@cbachhuber cbachhuber deleted the add-cpplint-whitespace-comments branch March 7, 2020 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants