-
Notifications
You must be signed in to change notification settings - Fork 380
Add and fix cpplint whitespace/comments #434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add and fix cpplint whitespace/comments #434
Conversation
Codecov Report
@@ Coverage Diff @@
## master #434 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 12 12
Lines 3582 3582
=====================================
Hits 3582 3582
Continue to review full report at Codecov.
|
clang-format now requires test code also in proper formatting. Should we add folder |
In general I think it is a good idea to treat the test code the same as the library code, so I would be in favor of running any checks on the test code. With the knowledge that I am pretty sure there are a few cases where we are purposely doing something Abnormal for the purpose of testing some aspect of the library, so there will likely be a few places where we have bypass the checks. |
I would enable the test checks in a separate PR though. |
I second that. Tests and (usually) examples should be included in checks. Second PR is best. |
Got it, I'll create a separate PR for including |
Finalizing the work started in #400 (and part of #378): this PR enables the cpplint check
whitespace/comments
and fixes corresponding issues.Also, it aligns the clang-format style to 2 spaces between code and trailing comments.