Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecated retired options #358

Merged
merged 11 commits into from
Dec 5, 2019
Merged

Deprecated retired options #358

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
fa086ec
add ability to specify deprecated or retired options.
phlptp Dec 1, 2019
1568e94
add retired example and tests
phlptp Dec 1, 2019
5a37076
update some formatting and a few more test executions
phlptp Dec 2, 2019
0037ca5
fix formatting on retired.cpp
phlptp Dec 2, 2019
39021de
add another test to fill coverage gap for existing options that are b…
phlptp Dec 2, 2019
884540e
add example comments
phlptp Dec 3, 2019
9b33653
Update readme with the descriptions of the new helper functions
phlptp Dec 3, 2019
a649b8d
fix space on readme
phlptp Dec 3, 2019
a80d909
Apply suggestions from code review
phlptp Dec 3, 2019
937dfe2
add some flags to the code coverage report and update some names and …
phlptp Dec 4, 2019
c326f73
update formatting on App
phlptp Dec 4, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix formatting on retired.cpp
  • Loading branch information
@phlptp
phlptp committed Dec 2, 2019
commit 0037ca5b8a7384ab623208629ffdb3caf5515a00
2 changes: 1 addition & 1 deletion examples/retired.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,5 +17,5 @@ int main(int argc, char **argv) {

CLI::deprecate_option(opt2, "--not_deprecated");

CLI11_PARSE(app, argc, argv);
CLI11_PARSE(app, argc, argv);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many other examples do a std::cout at the end, to show what is going on. Does that make sense here as well?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe something that prints out if the '--not_deprecated` or no options were passed, just so there is always guaranteed to be some output?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good suggestion, I like it!

}