Boost optional is no longer automatic #279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henryiii
force-pushed
the
henryiii-boptional
branch
from
c14199c
to
8d574ab
Compare
henryiii
force-pushed
the
henryiii-boptional
branch
3 times, most recently
from
a034624
to
15ae162
Compare
henryiii
force-pushed
the
henryiii-boptional
branch
from
15ae162
to
5a6e057
Compare
|
I think the main fix here is avoiding an unlimited number of parallel build jobs - for some reason Linux native really cared. But including boost::optional headers is a bit heavy and probably should only be explicit. std::optional is in the stdlib, so is something I feel okay including automatically if found. |
|
Build times are now down from 10-25 minutes to something like 5 for Linux native build. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checking to see if this faster. Drops the "automatic detection" of Boost for Boost::Optional.