Positional argument checks #262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #262 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 12 12
Lines 2710 2739 +29
=====================================
+ Hits 2710 2739 +29
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #262 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 12 12
Lines 2710 2737 +27
=====================================
+ Hits 2710 2737 +27
Continue to review full report at Codecov.
|
|
@phlptp, can you fix the conflict? I’ll be back from yet another conference on Tuesday. |
phlptp
force-pushed
the
Positional_argument_checks
branch
from
f04ce3c
to
c28f81a
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If merged this PR will add an option to require positional arguments to pass validation before matching. This would allow creating positionals for a file and number and allowing them to be entered in any order on the command line.
Modifications include adding
validate_positionalsfunction on Appmoving the
_validatecode into a separate function in options.removing the
set_resultsfunction in options which was being used by config file functions but it was bypassing some of the result processing, which could cause some issues if the delimiter option was also being used.Also tweaked the template for add_option to separate out the lexical_cast type from the assignment type if desired. (Probably need a few more tests of this yet).