Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add better enum support in the library #233

Merged
merged 2 commits into from
Feb 20, 2019

Conversation

phlptp
Copy link
Collaborator

@phlptp phlptp commented Feb 20, 2019

This PR is part of addressing #12. It adds better translation to/from enumerations.

@codecov
Copy link

codecov bot commented Feb 20, 2019

Codecov Report

Merging #233 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #233   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          12     12           
  Lines        2108   2112    +4     
=====================================
+ Hits         2108   2112    +4
Impacted Files Coverage Δ
include/CLI/TypeTools.hpp 100% <100%> (ø) ⬆️
include/CLI/ConfigFwd.hpp 100% <100%> (ø) ⬆️
include/CLI/StringTools.hpp 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 571fb07...98dd4e7. Read the comment docs.

add some helpers tests for enumerations

Add better enum support in the library
@henryiii henryiii merged commit 6c645b5 into CLIUtils:master Feb 20, 2019
@henryiii
Copy link
Collaborator

I like it, thanks! I think we can finally close #12! :)

@phlptp phlptp deleted the better_enum_support branch February 21, 2019 15:48
@henryiii henryiii added this to the v1.8 milestone Feb 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants