clear up some additional Wshadow warnings on older compilers #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #232 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 12 12
Lines 2087 2093 +6
=====================================
+ Hits 2087 2093 +6
Continue to review full report at Codecov.
|
|
So that's why you've been renaming those. Okay. |
phlptp
force-pushed
the
Wshadow-warnings
branch
from
9804ead
to
804c239
Compare
|
I kept getting a large number of warnings when trying to use CLI11 in some projects. I think most of the warnings on older gcc are mostly false positives but Wshadow has saved me a few times with the newer ones, so I like to leave it on. |
|
Looks good! Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds Wshadow flag and clears up some warnings