Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default delimiter to '\0' instead of space #221

Merged
merged 1 commit into from
Feb 8, 2019

Conversation

rafiw
Copy link
Contributor

@rafiw rafiw commented Feb 8, 2019

This maintains CLI11 previous way of work.
This fixes #218

Signed-off-by: Rafi Wiener rafiw@mellanox.com

This maintains CLI11 previous way of work.

Signed-off-by: Rafi Wiener <rafiw@mellanox.com>
@codecov
Copy link

codecov bot commented Feb 8, 2019

Codecov Report

Merging #221 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #221   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          12     12           
  Lines        2027   2033    +6     
=====================================
+ Hits         2027   2033    +6
Impacted Files Coverage Δ
include/CLI/App.hpp 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 048f968...472a695. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Feb 8, 2019

Codecov Report

Merging #221 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #221   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          12     12           
  Lines        2027   2033    +6     
=====================================
+ Hits         2027   2033    +6
Impacted Files Coverage Δ
include/CLI/App.hpp 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 048f968...472a695. Read the comment docs.

@henryiii henryiii merged commit 59ae97d into CLIUtils:master Feb 8, 2019
@henryiii
Copy link
Collaborator

henryiii commented Feb 8, 2019

Thanks!

@henryiii henryiii added this to the v1.8 milestone Feb 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Quoted arguments with spaces are split up
2 participants