Fix for GCC 8 warning

[henryiii]

This seems to be a bug in 1.7.0 introduced in #187; the == evaluates before the ?. GCC notices this and gives a warning.

[henryiii]

@phlptp, does this look right?

[phlptp]

yes the fix looks right.

[phlptp]

probably indicates there may be a missing test that would check the false branch of that if statement. If that statement was always evaluating to true (which would be by far the most common case) then it should be possible to craft a failing test case before the fix.

[henryiii]

I’m traveling till Tueday, could you make a test for it?

[codecov]

Codecov Report

Merging #201 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master   #201   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          12     12           
  Lines        1908   1908           
=====================================
  Hits         1908   1908

Impacted Files	Coverage Δ
include/CLI/StringTools.hpp	100% <100%> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 411364a...1777c91. Read the comment docs.

[codecov]

Codecov Report

Merging #201 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master   #201   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          12     12           
  Lines        1908   1908           
=====================================
  Hits         1908   1908

Impacted Files	Coverage Δ
include/CLI/StringTools.hpp	100% <100%> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 411364a...b84a2d0. Read the comment docs.

[henryiii]

Thanks!