Added option description setter #199

helmesjo · 2019-01-22T12:39:01Z

Option description can be modified after adding option.

Related: #193

…nst std::string&). Related: CLIUtils#193

henryiii

One minor comment. It would be nice to be able to edit the app description too.

include/CLI/Option.hpp

Format-fix to make clang-format happy.

codecov · 2019-01-22T12:57:21Z

Codecov Report

Merging #199 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master   #199   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          12     12           
  Lines        1902   1903    +1     
=====================================
+ Hits         1902   1903    +1

Impacted Files	Coverage Δ
include/CLI/Option.hpp	`100% <100%> (ø)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72c384c...be4fbbb. Read the comment docs.

codecov · 2019-01-22T12:57:22Z

Codecov Report

Merging #199 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master   #199   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          12     12           
  Lines        1902   1908    +6     
=====================================
+ Hits         1902   1908    +6

Impacted Files	Coverage Δ
include/CLI/Option.hpp	`100% <100%> (ø)`	⬆️
include/CLI/App.hpp	`100% <100%> (ø)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72c384c...7317e6a. Read the comment docs.

henryiii · 2019-01-22T13:15:31Z

If that passes CI, I'll merge. Are you planning to make one for App description, too?

…d::string&).

helmesjo · 2019-01-22T14:51:30Z

Are you planning to make one for App description, too?

Done!

henryiii · 2019-01-22T17:20:50Z

That looks great, thank you!

helmesjo · 2019-01-22T17:25:27Z

What's the ETA on the next release?

henryiii · 2019-01-22T21:40:55Z

Soon, 1 day to 1 week. Basically consider the current master an RC. Depends on how much testing I can do or if bugs are found.

helmesjo · 2019-01-23T07:23:41Z

Great!

helmesjo · 2019-01-23T07:27:36Z

When it's released, could you create an issue in bincrafters-community notifying about this? The conan package in question is conan-cli11. Or, just ping me and I'll do it. :)

henryiii · 2019-01-23T09:43:17Z

I'm going to see if I can get #200 in. It's a name change close to release, but the old behavior was dangerous. I'll ping you or open an issue when 1.7 is out! (PS: new releases show up in RSS form here:
https://github.com/CLIUtils/CLI11/releases.atom, or GitHub now lets you Watch -> Releases Only (which I have not tried, because I use the RSS feeds to watch projects, but sounds useful).

helmesjo · 2019-01-23T09:45:04Z

Sweet!
Oh yeah, forgot about that feature! 😇

henryiii · 2019-01-24T10:48:19Z

It's out! Can you raise the issue?

helmesjo · 2019-01-24T10:49:31Z

I'll fix!

henryiii · 2019-01-24T11:28:08Z

Just curious, how is bincrafters different from conan? I already have an official conan package that gets pushed out by the CI on tags.

helmesjo · 2019-01-24T11:43:37Z

Oh, alright. Yeah I can see you build conan packages, but they are never pushed to any repository, right?

Nah bincrafters is just a group of people doing great work of writing/collecting conan packages/recipes, build them on travis/appveyor and push all of the pre-built packages to their own repository on bintray.

Bincrafters host sort of an inofficial "official" conan repository, and over time packages are included in the official conan repository.

Perhaps @Croydon have some thoughts about where to go from here?

henryiii · 2019-01-24T11:48:33Z

Not sure how repositories work. I'm not using Conan at the moment, just providing packages. I'm happy to have them in bincrafters, just was checking to make sure work wasn't duplicated if unnecessary.

Packages are here: https://bintray.com/cliutils/CLI11

helmesjo · 2019-01-24T12:19:27Z

Ah, nice! I'll hand it over to @Croydon to take this forward. :) I guess you could submit an inclusion request into bincrafters, with you as official maintainer. That recipe would then solely wrap yours, or something like that. I don't know the specifics but something similar is being done for magnum.

helmesjo · 2019-01-24T15:16:05Z

In the meantime: bincrafters/community#619

Croydon · 2019-01-24T19:53:25Z

Hi! :)

I didn't follow this project so far, but from a quick look it seems like everything is already fine. Since CLI11 is header-only packaging + deploying is pretty simple. The recipe could need some more meta data like topics, author, homepage and the license field should be a SPDX identifier (https://spdx.org/licenses/), in general I recommend to have a look at https://github.com/bincrafters/conan-templates/blob/2dbf5261858c817faea420b3c32b7436f204fd85/header_only/conanfile.py#L8

CLI11 is already in conan-center so I'm not seeing any major things left to do here. @helmesjo What did you had in mind? Maybe the confusion comes because at Bincrafters we had a recipe as well, but we are stopping maintaining those when there is official support https://github.com/bincrafters/conan-cli11

helmesjo · 2019-01-24T20:14:38Z

Oh, I totally missed that it is already in conan-center..! 🤦‍♂️ I've been using the bincrafters-package since way back so just figured that was still the one... :)

Sorry for the confusion people! 😊

henryiii · 2019-01-24T21:41:12Z

@Croydon Thanks, I'll update the metadata soon (traveling for a few days).

helmesjo · 2019-01-28T12:10:12Z

So, I'm a little confused... (this is a conan/bintray question, but related to this release):

@Croydon mentioned that it is already part of conan-center, which one can see here when searching for CLI11. It is a so called "linked package" which is described by bintray as:

Linking a package to another user’s repository. A package that belongs to one repository may be linked and displayed as if it also belongs to another repository. This means that your package will be downloaded, visible in search results, and promoted just as much as the repository to which it is linked (in addition to, not instead of, the repository to which it actually belongs). This is one more option Bintray provides for cooperation between developers.

Given this, why can't I see this package locally when searching for cli11* on remote conan-center?
All I get is:

cli11/1.3.0@bincrafters/stable
cli11/1.4.0@bincrafters/stable
cli11/1.5.3@bincrafters/stable
cli11/1.6.0@bincrafters/stable
cli11/1.6.1@bincrafters/stable

Remote: https://api.bintray.com/conan/conan/conan-center (using the url displayed on bintray as https://dl.bintray.com/conan/conan-center does not work, it gives error ERROR: Not implemented endpoint. [Remote: https://conan.bintray.com]).

I'm missing some piece of the puzzle...

henryiii · 2019-01-28T13:25:09Z

Is there a way to update your cache, perhaps? I know Conan center/bin tray are very picky about caps, but that should be fine for the last several releases. I’m traveling without my computer, can test in a few days.

Croydon · 2019-01-28T16:29:22Z

conan search CLI11* -r conan-center

works for me as expected. The search is case-sensitive as such

conan search cli11* -r conan-center

only returns the results of our Bincrafters' recipe

helmesjo · 2019-01-28T20:31:57Z

Oh, wow. Case sensitivity totally got me... 🤦‍♂️ Yep, now I see it! :)

Thanks!

Added posibility to modify option description: Option::description(co…

791aa9a

…nst std::string&). Related: CLIUtils#193

henryiii reviewed Jan 22, 2019

View reviewed changes

include/CLI/Option.hpp Outdated Show resolved Hide resolved

Return Option* from Option::description(...).

be4fbbb

Format-fix to make clang-format happy.

Fixing format

b3ad215

Added posibility to modify app description: App::description(const st…

d910fbc

…d::string&).

henryiii added 2 commits January 22, 2019 17:52

Fixing Style

cb5900f

Update readme and changelog

7317e6a

henryiii merged commit 8d7aefe into CLIUtils:master Jan 22, 2019

helmesjo deleted the option-description-setter branch January 22, 2019 17:24

henryiii mentioned this pull request Jan 24, 2019

Adding metadata to conan #202

Merged

henryiii added this to the v1.7 milestone Feb 9, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added option description setter #199

Added option description setter #199

helmesjo commented Jan 22, 2019

henryiii left a comment

codecov bot commented Jan 22, 2019

codecov bot commented Jan 22, 2019 •

edited

Loading

henryiii commented Jan 22, 2019

helmesjo commented Jan 22, 2019

henryiii commented Jan 22, 2019

helmesjo commented Jan 22, 2019

henryiii commented Jan 22, 2019

helmesjo commented Jan 23, 2019

helmesjo commented Jan 23, 2019

henryiii commented Jan 23, 2019

helmesjo commented Jan 23, 2019

henryiii commented Jan 24, 2019

helmesjo commented Jan 24, 2019

henryiii commented Jan 24, 2019

helmesjo commented Jan 24, 2019 •

edited

Loading

henryiii commented Jan 24, 2019

helmesjo commented Jan 24, 2019

helmesjo commented Jan 24, 2019

Croydon commented Jan 24, 2019

helmesjo commented Jan 24, 2019

henryiii commented Jan 24, 2019

helmesjo commented Jan 28, 2019

henryiii commented Jan 28, 2019

Croydon commented Jan 28, 2019

helmesjo commented Jan 28, 2019

Added option description setter #199

Added option description setter #199

Conversation

helmesjo commented Jan 22, 2019

henryiii left a comment

Choose a reason for hiding this comment

codecov bot commented Jan 22, 2019

Codecov Report

codecov bot commented Jan 22, 2019 • edited Loading

Codecov Report

henryiii commented Jan 22, 2019

helmesjo commented Jan 22, 2019

henryiii commented Jan 22, 2019

helmesjo commented Jan 22, 2019

henryiii commented Jan 22, 2019

helmesjo commented Jan 23, 2019

helmesjo commented Jan 23, 2019

henryiii commented Jan 23, 2019

helmesjo commented Jan 23, 2019

henryiii commented Jan 24, 2019

helmesjo commented Jan 24, 2019

henryiii commented Jan 24, 2019

helmesjo commented Jan 24, 2019 • edited Loading

henryiii commented Jan 24, 2019

helmesjo commented Jan 24, 2019

helmesjo commented Jan 24, 2019

Croydon commented Jan 24, 2019

helmesjo commented Jan 24, 2019

henryiii commented Jan 24, 2019

helmesjo commented Jan 28, 2019

henryiii commented Jan 28, 2019

Croydon commented Jan 28, 2019

helmesjo commented Jan 28, 2019

codecov bot commented Jan 22, 2019 •

edited

Loading

helmesjo commented Jan 24, 2019 •

edited

Loading