Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dropping links if option removed #179

Merged
merged 1 commit into from
Nov 13, 2018
Merged

Dropping links if option removed #179

merged 1 commit into from
Nov 13, 2018

Conversation

henryiii
Copy link
Collaborator

This should address #172.

@codecov
Copy link

codecov bot commented Nov 12, 2018

Codecov Report

Merging #179 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #179      +/-   ##
==========================================
+ Coverage   99.94%   99.94%   +<.01%     
==========================================
  Files          12       12              
  Lines        1711     1726      +15     
==========================================
+ Hits         1710     1725      +15     
  Misses          1        1
Impacted Files Coverage Δ
include/CLI/Option.hpp 100% <100%> (ø) ⬆️
include/CLI/App.hpp 99.86% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b683f4e...82469c1. Read the comment docs.

@OlivierHartmann
Copy link

Thank you for this patch !

@henryiii henryiii deleted the remove_links branch November 13, 2018 20:39
@henryiii henryiii added this to the v1.7 milestone Jan 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants