Skip to content

fix: support wide strings for app description and usage - #1439

Open
ThunderKhan wants to merge 1 commit into
CLIUtils:mainfrom
ThunderKhan:fix/1130-windows-unicode-usage
Open

fix: support wide strings for app description and usage#1439
ThunderKhan wants to merge 1 commit into
CLIUtils:mainfrom
ThunderKhan:fix/1130-windows-unicode-usage

Conversation

@ThunderKhan

Copy link
Copy Markdown
Contributor

Closes #1130.

Summary

Adds support for wide strings in the CLI::App description constructor and usage() setter.

Changes

  • Add a std::wstring overload for the CLI::App description constructor.
  • Add a std::wstring overload for App::usage().
  • Convert wide strings through CLI11's existing narrow() helper and delegate to the existing std::string implementations.
  • Add a regression test covering wide string literals with non-ASCII Unicode characters.

Testing

  • Added a regression test reproducing the previously unsupported wide-string calls.
  • Verified the regression test fails to compile without the new overloads.
  • Built successfully with C++11.
  • Ran the full test suite: 83/83 tests passed.
  • Ran prek successfully.
  • Ran git diff --check successfully.

@codecov

codecov Bot commented Aug 14, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (75933a4) to head (a476824).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1439   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           20        20           
  Lines         5234      5236    +2     
  Branches      1132      1132           
=========================================
+ Hits          5234      5236    +2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for Unicode string in app usage under windows

1 participant