Module testing #1255
Module testing #1255
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1255 +/- ##
===========================================
Coverage 100.00% 100.00%
===========================================
Files 17 19 +2
Lines 4546 5039 +493
Branches 0 1077 +1077
===========================================
+ Hits 4546 5039 +493 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
phlptp
force-pushed
the
module_testing
branch
from
49f58ac to
42f2833
Compare
phlptp
force-pushed
the
module_testing
branch
from
bf18761 to
21bd7b4
Compare
phlptp
force-pushed
the
module_testing
branch
from
2772a41 to
d4d99b6
Compare
phlptp
force-pushed
the
module_testing
branch
from
b75da50 to
88156f4
Compare
phlptp
force-pushed
the
module_testing
branch
2 times, most recently
from
abe3b74 to
54b4414
Compare
phlptp
force-pushed
the
module_testing
branch
from
52899dc to
75e0a18
Compare
phlptp
force-pushed
the
module_testing
branch
from
3bed773 to
dd8ca49
Compare
| set(CMAKE_PREFIX_PATH ${CLI11_DIR}) | ||
| endif() | ||
|
|
||
| set(CMAKE_CXX_STANDARD 23) |
There was a problem hiding this comment.
This could be 20 as well?
| /// a constant defining an expected max vector size defined to be a big number that could be multiplied by 4 and not | ||
| /// produce overflow for some expected uses | ||
| constexpr int expected_max_vector_size{1 << 29}; | ||
| CLI11_MODULE_INLINE constexpr int expected_max_vector_size{1 << 29}; |
There was a problem hiding this comment.
By the way, can we not have inline here all the time?
There was a problem hiding this comment.
inline constexpr variables are only available in C++17, so putting inline here doesn't compile on on C++11
There was a problem hiding this comment.
But could it be based on C++ level, then? It would be nice not to have more config options if possible.
There was a problem hiding this comment.
seems to work if I condition on C++17 and have it be inline or static, will go with that.
Co-authored-by: Henry Schreiner <HenrySchreinerIII@gmail.com>
2 participants
Address issue #1254