Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1025 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 17 17
Lines 4546 4557 +11
Branches 0 971 +971
==========================================
+ Hits 4546 4557 +11 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Pretty sure this is the wrong directory - I think you meant include/meson.build, since CLI11.hpp sits inside include in the current CMake build.
Even so, I'm still not very fond of the idea of playing anything besides headers inside /include. It's valid to -I include it, and it seems weird to have meson files there too. Maybe it would be better to make a new dir, single-include, and place meson.build and the single file output there. We could also move the CMake output there, and even put the CMake single header file code there too.
See #1025. --------- Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
|
I've moved the single file to it's own folder, so now it should be possible to avoid the meson.build file inside the include dir. |
…dir` The latter has been deprecated due to it's ambiguity.
It's not used.
This models the upstream recommendation that consumers avoid the
`subproject('CLI11').get_variable('dep_cli11')` pattern, and instead
simply use `dependency('CLI11')`. This allows build scripts to switch
between system provided dependencies found with pkg-config or cmake, and
subprojects configured and built with the main project without
modification to the build scripts. Users can use the Meson options
`--wrap-mode` and `--force-fallback-for` to get the behavior that they
want.
I have added the `--force-fallback-for=CLI11` switch to the CI to ensure
that the test continues to exercise what it's intended to.
This should be a replica of what the CMake does
Tries to match the CMake behavior. It does fail in the Helper tests, but I was unable to get CMake to build the pre-compiled configuration at all.
Since this section is still about CMake
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
henryiii
force-pushed
the
submit/more-meson-work
branch
from
1c465d6 to
8267dde
Compare
2 participants
This is follow up work to my previous series. I've tried to make the Meson build mirror the CMake build more closely. I've also made an attempt at adding some instructions to the documents on using Meson.