Skip to content

Conversation

emanuel-schmid
Copy link
Collaborator

@emanuel-schmid emanuel-schmid commented Sep 12, 2024

Changes proposed in this PR:

  • optionally change variable names of eccodes 'gust' variable to allow updating to eccodes > 2.27

This PR fixes #678

PR Author Checklist

PR Reviewer Checklist

@emanuel-schmid emanuel-schmid changed the title eccodes changed variable names: i.p., gust -> i10fg eccodes dependency update Sep 12, 2024
@mmyrte
Copy link
Collaborator

mmyrte commented Sep 13, 2024

Hi @emanuel-schmid, I'm not at all in the know about eccodes and the grib-files being read. I avoided adding eccodes to the dependencies in summer 2020 because it's not pure Python, and because I was only reading minimal amounts of bufr files. I suppose that @ThomasRoosli is much closer to the subject at hand...

@emanuel-schmid
Copy link
Collaborator Author

@mmyrte 👍 fair enough. thanks for the note!

@emanuel-schmid emanuel-schmid removed the request for review from mmyrte September 13, 2024 15:08
@chahank
Copy link
Member

chahank commented Dec 10, 2024

@emanuel-schmid Any plans to finish this PR? Are more inputs needed?

# Conflicts:
#	doc/tutorial/climada_engine_Forecast.ipynb
#	doc/tutorial/climada_engine_Impact.ipynb
#	doc/tutorial/climada_entity_Exposures.ipynb
#	doc/tutorial/climada_entity_LitPop.ipynb
#	doc/tutorial/climada_hazard_TropCyclone.ipynb
@emanuel-schmid
Copy link
Collaborator Author

This is ready to merge, I'd say.
After having a closer look at StormEurope.from_icon_grib I assume that xr.open_dataset(gripfile_path_i, engine="cfgrib") simply assigns another label to the data set values starting with eccodes 2.28. At least the data suggests so.

@emanuel-schmid emanuel-schmid merged commit 16792b8 into develop Feb 11, 2025
14 of 19 checks passed
@emanuel-schmid emanuel-schmid deleted the feature/update_eccodes branch February 11, 2025 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants