Handling lines & polygons as exposures for impact calcs#351
Merged
emanuel-schmid merged 184 commits intodevelopfrom Jun 28, 2022
Merged
Handling lines & polygons as exposures for impact calcs#351emanuel-schmid merged 184 commits intodevelopfrom
emanuel-schmid merged 184 commits intodevelopfrom
Conversation
Member
Author
For me it now works (the correct file gets downloaded). Thus, all the tests seem to be working fine. Let's see what the jenkins build will tell. |
Member
Author
For me locally it works all good for now. |
… feature/lines_polygons_exp
… feature/lines_polygons_exp
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request is to discuss the updates of the util functions to handle lines and polygons. This is a follow-up of #221.
It is now possible to compute directly the impact for exposures with polygons and/or lines geometries. There are methods to disaggregate polygons/lines to points, with wrappers for geodataframes and exposures. There are methods to aggregate the impact per point to geometries.
The final outcome is an
Impactobject, which has one new attribute containing the geometries of the original exposure. This allows plotting the impact per geometry with a new method.This pull request also contains some of the methods proposed in #350. The methods here are in the
util.lines_polygon_handlermodule. This is because they were first made for use in this module only. If #350 is succesful, the code can then be adapted easily.