Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lab02 debugging: Akiko Zhu #13

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

AkikozZM
Copy link

Shadertoy
I fixed the following bugs in this lab02 project

  • Syntax error:
    • vec uv should be vec2 uv
  • Argument input error:
    • should put uv2 in the raycast function instead of uv, so that the camera can correctly see the entire scene
  • iResolution error:
    • should change iResolution.x / iResolution.x to iResolution.x / iResolution.y so that the camera will not be distorted
  • Ray march limit error:
    • should increase the maximum distance(i < 256 instead of i < 64) that ray can march the scene object so that the camera can see the further floor
  • Reflection error:
    • this one is very tricky, should plug dir into the reflect function instead of eye

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant