Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

icepack_parameters: don't recompute constants in icepack_query_parameters #465

Merged
merged 1 commit into from
Oct 12, 2023
Merged

icepack_parameters: don't recompute constants in icepack_query_parameters #465

merged 1 commit into from
Oct 12, 2023

Conversation

phil-blain
Copy link
Member

PR checklist

  • Short (1 sentence) summary of your PR:
    icepack_parameters: don't recompute constants in icepack_query_parameters
  • Developer(s):
    me
  • Suggest PR reviewers from list in the column to the right.
  • Please copy the PR test results link or provide a summary of testing completed below.
    Tested by code inspection.
  • How much do the PR code changes differ from the unmodified code?
    • bit for bit
    • different at roundoff level
    • more substantial
  • Does this PR create or have dependencies on CICE or any other models?
    • Yes
    • No
  • Does this PR add any new test cases?
    • Yes
    • No
  • Is the documentation being updated? ("Documentation" includes information on the wiki or in the .rst files from doc/source/, which are used to create the online technical docs at https://readthedocs.org/projects/cice-consortium-cice/.)
    • Yes
    • No, does the documentation need to be updated at a later time?
      • Yes
      • No
  • Please provide any additional information or relevant details below:

All parameters of icepack_parameters::icepack_query_parameters are intent(out), so it does not make sense to recompute constants at the end of that subroutine since no constants are changed. This superfluous call dates back to the introduction of icepack_query_parameters (then called icepack_query_constants) in 7646f2a (Migrate icepack_constants out of the columnphysics/constants directory..., 2017-10-04).

Remove that call.

@phil-blain
icepack_parameters: don't recompute constants in icepack_query_parame…
89f065f 
…ters

All parameters of icepack_parameters::icepack_query_parameters are
intent(out), so it does not make sense to recompute constants at the end
of that subroutine since no constants are changed. This superfluous call
dates back to the introduction of icepack_query_parameters (then called
icepack_query_constants) in 7646f2a (Migrate icepack_constants out of
the columnphysics/constants directory..., 2017-10-04).

Remove that call.
@phil-blain phil-blain requested a review from apcraig October 11, 2023 14:00
apcraig
apcraig approved these changes Oct 11, 2023
View reviewed changes
Copy link
Contributor

@apcraig apcraig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense.

Doc generation being updated in #466

@apcraig apcraig merged commit 182030d into CICE-Consortium:main Oct 12, 2023
@phil-blain phil-blain deleted the query-params-dont-recompute branch January 24, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apcraig apcraig apcraig approved these changes

Assignees
No one assigned
Labels
Software Engineering
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@phil-blain @apcraig