-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Old aerosol bug fix (tr_aero). #330
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't fully understand why this is wrong but will take your word for it! I think the confusion is related to CICE-Consortium/CICE#67
This impacts fluxes like melts, congel, snoice, etc. These are m/s fluxes from the thermodynamics are are not "volume" related. So, they don't need to be divided by aice. |
For detailed information about submitting Pull Requests (PRs) to the CICE-Consortium,
please refer to: https://github.com/CICE-Consortium/About-Us/wiki/Resource-Index#information-for-developers
PR checklist
This is a bug fix to the old aerosol scheme (tr_aero). Some quantities were divided by aice and should not have been.
dabail10 (D. Bailey)
https://github.com/CICE-Consortium/Test-Results/wiki/icepack_by_mach_forks#izumi
The only Icepack test in the base_suite that is not bfb is the pondcesm test. Also, in the CICE base_suite the only test that is not bfb is the alt04. Curiously alt03 is bfb even though tr_aero is on here. There is some interaction of the topographic ponds and the aerosols that I have not figured out. Here are the QC results from alt04. They passed. This addresses Issue CICE-Consortium/CICE#483