Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multi-pe advection=none bug #664

Merged
merged 5 commits into from
Nov 26, 2021
Merged

Fix multi-pe advection=none bug #664

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
dc1269b
update parsing scripts to improve robustness, fix multi-pe advection=…
apcraig Nov 18, 2021
60816b1
Update cice script to improve performance including
apcraig Nov 23, 2021
4c7987e
fix cice.setup for case
apcraig Nov 23, 2021
14c436e
add sedbak implementation to support Mac sed
apcraig Nov 23, 2021
80c407a
s/spend/spent
apcraig Nov 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix cice.setup for case
  • Loading branch information
@apcraig
apcraig committed Nov 23, 2021
commit 4c7987e42178762c1226590c0d28c02901dab148
2 changes: 1 addition & 1 deletion cice.setup
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -938,9 +938,9 @@ EOF

# Use an existing ice_in file from the suite if it exists
# to reduce time spend in parse_namelist
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/spend/spent/

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixing.

set iceinfn = ../ice_in_save_${grid}${soptions}
set skip_parse_namelist = spval
if (${dosuite} == 1) then
set iceinfn = ../ice_in_save_${grid}${soptions}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I'd maybe prefer we put the saved namelists in a separate directory, so as to not clutter the suite's top level directory, but I don't have that strong of an opinion about it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These sit in the test suite directory and are deleted at the end of the test suite. You're right that it may be cleaner to put them in a separate directory, but I think we're OK for now.

if (-e ${iceinfn}) then
echo "use ${iceinfn}"
cp ${iceinfn} ice_in
Expand Down