Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove INTEL20_WORKAROUND and port to mustang #462

Merged
merged 1 commit into from
Jun 9, 2020
Merged

remove INTEL20_WORKAROUND and port to mustang #462

merged 1 commit into from
Jun 9, 2020

Conversation

apcraig
Copy link
Contributor

@apcraig apcraig commented Jun 8, 2020

PR checklist

  • Short (1 sentence) summary of your PR:
    remove INTEL20_WORKAROUND and port to mustang
  • Developer(s):
    apcraig
  • Suggest PR reviewers from list in the column to the right.
  • Please copy the PR test results link or provide a summary of testing completed below.
    Tested with 3 intel compiler versions on mustang
    https://github.com/CICE-Consortium/Test-Results/wiki/cice_by_mach_forks#mustang
  • How much do the PR code changes differ from the unmodified code?
    • bit for bit
    • different at roundoff level
    • more substantial
  • Does this PR create or have dependencies on Icepack or any other models?
    • Yes
    • No
  • Does this PR add any new test cases?
    • Yes
    • No
  • Is the documentation being updated? ("Documentation" includes information on the wiki or in the .rst files from doc/source/, which are used to create the online technical docs at https://readthedocs.org/projects/cice-consortium-cice/. A test build of the technical docs will be performed as part of the PR testing.)
    • Yes
    • No, does the documentation need to be updated at a later time?
      • Yes
      • No
  • Please provide any additional information or relevant details below:

Ported to intel18, intel19, and intel20 compiler modules. Initial testing was in debug queue, will retest with standard queue to make sure longer tests execute.

dabail10
dabail10 approved these changes Jun 8, 2020
View reviewed changes
Copy link
Contributor

@dabail10 dabail10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@apcraig
Copy link
Contributor Author

apcraig commented Jun 8, 2020

The full test suite is here and all tests pass on Mustang with 3 different intel compilers.

https://github.com/CICE-Consortium/Test-Results/wiki/cice_by_hash_forks#89641bbf413003c5c9b1192c9f3e8a82775a1e36

eclare108213
eclare108213 approved these changes Jun 9, 2020
View reviewed changes
Copy link
Contributor

@eclare108213 eclare108213 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this better, thanks.

@apcraig apcraig merged commit f31cfc9 into CICE-Consortium:master Jun 9, 2020
@apcraig apcraig mentioned this pull request Jul 1, 2020
Open
@apcraig apcraig deleted the mustangA branch August 17, 2022 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eclare108213 eclare108213 eclare108213 approved these changes

@dabail10 dabail10 dabail10 approved these changes

Assignees
No one assigned
Labels
Porting Priority: High
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@apcraig @eclare108213 @dabail10