-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update code coverage documentation #436
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
364bfd1
update code coverage documentation
apcraig 79556be
remove cice_test_codecov script
apcraig 37668e1
update code coverage documentation
apcraig 518570f
update codecov documentation
apcraig 54e325a
Update configuration/scripts/tests/cice_test_codecov.csh
apcraig a7338dc
update codecov script and documentation
apcraig ce1c5df
Merge branch 'codecov3' of https://github.com/apcraig/cice into codecov3
apcraig File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,75 @@ | ||
#!/bin/csh | ||
|
||
# This was a script on gordon | ||
# This script should only be run on hardware with the gnu compiler with a | ||
# modified Macros file to turn on the codecov flags | ||
# This should be run interactively because git push will require login information | ||
|
||
#PBS -N cice_test | ||
#PBS -q standard | ||
#PBS -A NRLSS03755018 | ||
#PBS -l application=Regional-Arctic-System-Model | ||
#PBS -l select=1:ncpus=32:mpiprocs=32 | ||
#PBS -l walltime=24:00:00 | ||
#PBS -j oe | ||
#PBS -M anthony.p.craig@gmail.com | ||
#PBS -m be | ||
|
||
#set verbose | ||
module load costinit git | ||
|
||
set scrdir = "~" | ||
set testdir = "~/cice_testing" | ||
set date0 = `date -u "+%y%m%d"` | ||
set date = ${date0}cc | ||
|
||
mkdir -p ${testdir} | ||
|
||
cd ${testdir} | ||
|
||
# Check out current cice master | ||
echo " " | ||
echo "*** checkout current cice master ***" | ||
git clone https://github.com/cice-consortium/cice cice.master.${date} --recursive | ||
cd cice.master.${date} | ||
set hash = `git rev-parse --short HEAD ` | ||
cd ../ | ||
|
||
# Check out test_cice_icepack, remove all code and copy from cice master | ||
# Need to be careful about dot files, particularly .git* files | ||
# This copies in all files via standard file expansion (except dot files at root) | ||
# This also copies in all dot file at the root that do not start with .g (ie. .git*) | ||
echo " " | ||
echo "*** checkout current test_cice_master ***" | ||
git clone https://github.com/apcraig/test_cice_icepack test_cice_icepack.${date} | ||
cd test_cice_icepack.${date} | ||
echo " " | ||
echo "*** remove current files and copy in cice master files ***" | ||
set verbose | ||
git rm -r * >& /dev/null | ||
cp -p -r ../cice.master.${date}/* . | ||
cp -p ../cice.master.${date}/.[a-f,h-z]* . | ||
|
||
# Clean up icepack .git stuff and commit | ||
rm -r -f icepack/.git* | ||
git add . | ||
unset verbose | ||
echo " " | ||
echo "*** git status of changes ***" | ||
git status | ||
echo " " | ||
echo "*** commit changes ***" | ||
git commit -m "update test_cice_icepack master to ${hash}" | ||
|
||
# Push test_cice_icepack | ||
echo " " | ||
echo "*** push changes to test_cice_icepack ***" | ||
git push origin master | ||
|
||
# Run test suite | ||
echo " " | ||
echo "*** run test suite ***" | ||
./cice.setup --suite first_suite,base_suite,travis_suite,decomp_suite,reprosum_suite,quick_suite -m gordon -e gnu --testid T${date} --codecov --queue standard | ||
|
||
# The test suite will wait until all jobs are complete then run report_codecov.csh | ||
# If that fails, you can run report_codecov.csh manually after all jobs are done |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if the clone is done using SSH (
git@github.com:apcraig/Test_CICE_Icepack.git
) instead of HTTPS, the script will not ask for a password forgit push
as long as the SSH keys are correctly configuredThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, if we want to this to be easier to setup for others, I think the username (here
apcraig
) should be a script parameter, or at least an environment variable.But as I wrote in #89 (comment), I think it would be more "official" if the "test_cice_icepack" repo (or whatever we call it) was under the CICE-Consortium organization no ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @phil-blain. We could use ssh, but I'm not sure it's worth setting up the ssh keys for occasional testing. Putting in a username and password doesn't seem like a large burden or hurdle.
I have given a few people access to the test_cice_icepack repo. You should be able to push to that repo using your own username/password. Or are you suggesting that the "organization" name be a variable? My idea is that a handful of us will have access to the repo under "apcraig", and we'll use it for now. I don't see any value in setting up the equivalent repo under multiple users. If we did that, we'd end up needing to test/change a few other things including the codecov location and the token string that connects github and codecov. It seems just easier to give a subset of folks write access to my test_cice_icepack repo. It's just a temporary repo and if it's get trashed, it's not a big deal. Every use basically removes all files and adds them all back again anyway.
I replied in #89 that I would prefer to keep the test_cice_icepack repo hidden and out of the CICE-Consortium. My hope is that it's temporary (until codecov supports submodules although I don't have a lot of optimism), and I prefer the fake repo not be visible to the community in general, especially since it's not part of the standard workflow and testing. I think it can only create confusion in the community. It would be easy to migrate test_cice_icepack to the consortium org if others felt it was better there though.