Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update test reporting #428

Merged
merged 1 commit into from
Apr 10, 2020
Merged

Conversation

apcraig
Copy link
Contributor

@apcraig apcraig commented Apr 3, 2020

PR checklist

  • Short (1 sentence) summary of your PR:
    Update test reporting
  • Developer(s):
    apcraig
  • Suggest PR reviewers from list in the column to the right.
  • Please copy the PR test results link or provide a summary of testing completed below.
    Only scripts are changing. I have done a number of tests to verify the scripts seem to behave as expected including testing the results and report_results scripts.
  • How much do the PR code changes differ from the unmodified code?
    • bit for bit
    • different at roundoff level
    • more substantial
  • Does this PR create or have dependencies on Icepack or any other models?
    • Yes
    • No
  • Does this PR add any new test cases?
    • Yes
    • No
  • Is the documentation being updated? ("Documentation" includes information on the wiki or in the .rst files from doc/source/, which are used to create the online technical docs at https://readthedocs.org/projects/cice-consortium-cice/. A test build of the technical docs will be performed as part of the PR testing.)
    • Yes
    • No, does the documentation need to be updated at a later time?
      • Yes
      • No
  • Please provide any additional information or relevant details below:

This addresses Icepack #309.

  • This includes an upgrade to the test reporting by removing the RUN outcome and doing a more careful job of defining and counting the results.

  • Unique filenames are now generated everytime report_results.csh is run. Prior to this, running report_results.csh multiple times in a test suite would just overwrite the same detailed wiki page.

  • report_results.csh now automatically runs results.csh. Prior to this, it did not. To turn off the feature, report_results.csh -n can be invoked.

Copy link
Member

@phil-blain phil-blain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took a quick glance and this looks good to me.

@apcraig apcraig merged commit 1c6c225 into CICE-Consortium:master Apr 10, 2020
@apcraig apcraig deleted the test_report branch August 17, 2022 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants