Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update wave_spec_frac filename implementation and update icepack #417

Merged
merged 2 commits into from
Mar 13, 2020

Conversation

apcraig
Copy link
Contributor

@apcraig apcraig commented Mar 13, 2020

PR checklist

  • Short (1 sentence) summary of your PR:
    Update wave_spec_frac filename and update Icepack
  • Developer(s):
    apcraig
  • Suggest PR reviewers from list in the column to the right.
  • Please copy the PR test results link or provide a summary of testing completed below.
    Tested a couple days ago, https://github.com/CICE-Consortium/Test-Results/wiki/cice_by_hash_forks#7e2a1d99974d21c28a0983721a2453fbf14adbfe. Retesting again with clean sandbox produces same results, https://github.com/CICE-Consortium/Test-Results/wiki/cice_by_hash_forks#e3ce8dcf9b088ce90b4b85dda1e67305064d2c52
  • How much do the PR code changes differ from the unmodified code?
    • bit for bit
    • different at roundoff level
    • more substantial
  • Does this PR create or have dependencies on Icepack or any other models?
    • Yes, requires latest version of Icepack due to new optional icepack_fsd_init_bounds argument to control diagnostic writes
    • No
  • Does this PR add any new test cases?
    • Yes
    • No
  • Is the documentation being updated? ("Documentation" includes information on the wiki or in the .rst files from doc/source/, which are used to create the online technical docs at https://readthedocs.org/projects/cice-consortium-cice/. A test build of the technical docs will be performed as part of the PR testing.)
    • Yes
    • No, does the documentation need to be updated at a later time?
      • Yes
      • No
  • Please provide any additional information or relevant details below:

Addresses #415

@apcraig
Copy link
Contributor Author

apcraig commented Mar 13, 2020

@lettie-roach, this modification updates the wave_spec_frac filename implementation, so now that namelist defines the path and filename. It should be easier to use with that change. This PR also brings in the lastest Icepack changes that include the update to the random wavespec algorithm. If you have a chance to review, that would be great. If not, I'll probably merge today to include in weekend testing. Thanks!

@lettie-roach
Copy link
Contributor

lettie-roach commented Mar 13, 2020 via email

@apcraig apcraig merged commit 771aecb into CICE-Consortium:master Mar 13, 2020
@apcraig apcraig deleted the wave_spec_file_in branch August 17, 2022 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants