Updated dmi drivers according to standalone

[TillRasmussen]

For detailed information about submitting Pull Requests (PRs) to the CICE-Consortium,
please refer to: https://github.com/CICE-Consortium/About-Us/wiki/Resource-Index#information-for-developers

PR checklist

• Short (1 sentence) summary of your PR:
  Cleanup, allowed hycom_atm_data to have leap year and update dmi driver to reflect changes in standalone driver
• Developer(s):
  tar
• Suggest PR reviewers from list in the column to the right. Tony+Elizabeth
• Please copy the PR test results link or provide a summary of testing completed below.
  Limited differences in standalone code. This changes dmi driver according to updated standalone driver
• How much do the PR code changes differ from the unmodified code?
  • bit for bit
  • different at roundoff level
  • more substantial
• Does this PR create or have dependencies on Icepack or any other models?
  • Yes
  • No
• Does this PR add any new test cases?
  • Yes
  • No
• Is the documentation being updated? ("Documentation" includes information on the wiki or in the .rst files from doc/source/, which are used to create the online technical docs at https://readthedocs.org/projects/cice-consortium-cice/. A test build of the technical docs will be performed as part of the PR testing.)
  • Yes
  • No, does the documentation need to be updated at a later time?
    • Yes
    • No Unless the addition of leap years to hycom_atm_data should be documented
• Please provide any additional information or relevant details below:
  This should not change results. I have removed comments from ice_grid related to the calculation of anglet. Mostly added keywords to dmi driver as required by the updated icepack. At last allowed for hycom atm data to use leap years.

[eclare108213]

what is lal.dat?

[apcraig]

This looks like an error. You probably need ! in front.

[TillRasmussen]

Yes your are right.

[apcraig]

I'm a little confused what the Icepack change is. Is that supposed to be there and what is it doing?

[apcraig]

travis is not passing. I believe it cannot find the Icepack submodule version or change that's in this PR. That should be fixed and reset to the current CICE Icepack version, 68bc397. If you need some help with that, let me know.

[TillRasmussen]

Yes I needed to add "!"
lal.dat was a file that contained some diffs. (git diff ....). This has been removed
Icepack was the last (hopefully) leftover of my fork being corrupted when linked to icepack.
Pull should be updated. Check is ongoing

[phil-blain]

@TillRasmussen if you (re)take a look at https://github.com/CICE-Consortium/About-Us/wiki/Git-Workflow-Guidance maybe it will clarify things for you regarding how to deal with icepack. I added more details to that page. Essentially each time you switch branches with git checkout you have to follow with git submodule update for the Icepack submodule to stay in sync with the current branch. Same thing when you git pull, you have to follow with git submodule update.

[TillRasmussen]

thanks, I did manage to get through. Till

…

On Thu, Dec 5, 2019 at 4:01 PM Philippe Blain ***@***.***> wrote: @TillRasmussen <https://github.com/TillRasmussen> if you (re)take a look at https://github.com/CICE-Consortium/About-Us/wiki/Git-Workflow-Guidance maybe it will clarify things for you regarding how to deal with icepack. I added more details to that page. Essentially each time you switch branches with git checkout you have to follow with git submodule update for the Icepack submodule to stay in sync with the current branch. Same thing when you git pull, you have to follow with git submodule update. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#383?email_source=notifications&email_token=AH7N7DVTKAJSCNVVNWHKJATQXEJVPA5CNFSM4JTNR4U2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEGA7ZZI#issuecomment-562167013>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AH7N7DVKUC5MBLN6ZW5HWCLQXEJVPANCNFSM4JTNR4UQ> .