Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update zenodo json template and report_results script #370

Merged
merged 4 commits into from
Oct 22, 2019

Conversation

apcraig
Copy link
Contributor

@apcraig apcraig commented Oct 19, 2019

PR checklist

  • Short (1 sentence) summary of your PR:
    Update zenodo json template and report_results script
  • Developer(s):
    apcraig
  • Suggest PR reviewers from list in the column to the right.
  • Please copy the PR test results link or provide a summary of testing completed below.
    Ran quick suite on gordon and report_results seems fine. hash #333a5a28ccd0b at https://github.com/CICE-Consortium/Test-Results/wiki/cice_by_hash_forks on Oct 18.
    Zenodo changes will have to be tested in the future.
  • How much do the PR code changes differ from the unmodified code?
    • bit for bit
    • different at roundoff level
    • more substantial
  • Does this PR create or have dependencies on Icepack or any other models?
    • Yes
    • No
  • Does this PR add any new test cases?
    • Yes
    • No
  • Is the documentation being updated? ("Documentation" includes information on the wiki or in the .rst files from doc/source/, which are used to create the online technical docs at https://readthedocs.org/projects/cice-consortium-cice/. A test build of the technical docs will be performed as part of the PR testing.)
    • Yes
    • No, does the documentation need to be updated at a later time?
      • Yes
      • No
  • Please provide any additional information or relevant details below:

Zenodo json update based on feedback from zenodo folks. will test on next release.
Updated report_results to remove some of the reports and sync the icepack and CICE report_results script again.
Also updated .gitignore to ignore testsuite directories.

Copy link
Contributor

@eclare108213 eclare108213 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine, but I wonder about the "scheme": "doi" line. Scheme isn't listed as an option for related_identifiers in the doc Zenodo sent us to. It says the type (doi etc) is detected automatically. Maybe those should be left out? Or hopefully they're okay, backward compatible. You could also change @mattdturner 's affiliation, as long as you're doing a PR on this. Thanks @apcraig !

@apcraig
Copy link
Contributor Author

apcraig commented Oct 19, 2019

I just updated the zenodo json file as suggested. I am running the full test suite on gordon on 4 compilers and everything looks bit-for-bit with the current master. I will post results when all tests are thru the queue, but I think it's all fine and we can move forward.

@@ -7,3 +7,6 @@ doc/build

# Ignore macOS cache files
.DS_Store

# Ignore testsuite file/directories
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess while we are at it we could also ignore caselist.* files generated by cice.setup

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good idea, i'll add that in both cice and icepack and update shortly.

@apcraig apcraig self-assigned this Oct 21, 2019
@apcraig apcraig merged commit 2a2b107 into CICE-Consortium:master Oct 22, 2019
@apcraig apcraig deleted the zeno branch August 17, 2022 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants