-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update zenodo json template and report_results script #370
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks fine, but I wonder about the "scheme": "doi" line. Scheme isn't listed as an option for related_identifiers in the doc Zenodo sent us to. It says the type (doi etc) is detected automatically. Maybe those should be left out? Or hopefully they're okay, backward compatible. You could also change @mattdturner 's affiliation, as long as you're doing a PR on this. Thanks @apcraig !
I just updated the zenodo json file as suggested. I am running the full test suite on gordon on 4 compilers and everything looks bit-for-bit with the current master. I will post results when all tests are thru the queue, but I think it's all fine and we can move forward. |
@@ -7,3 +7,6 @@ doc/build | |||
|
|||
# Ignore macOS cache files | |||
.DS_Store | |||
|
|||
# Ignore testsuite file/directories |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess while we are at it we could also ignore caselist.*
files generated by cice.setup
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good idea, i'll add that in both cice and icepack and update shortly.
PR checklist
Update zenodo json template and report_results script
apcraig
Ran quick suite on gordon and report_results seems fine. hash #333a5a28ccd0b at https://github.com/CICE-Consortium/Test-Results/wiki/cice_by_hash_forks on Oct 18.
Zenodo changes will have to be tested in the future.
Zenodo json update based on feedback from zenodo folks. will test on next release.
Updated report_results to remove some of the reports and sync the icepack and CICE report_results script again.
Also updated .gitignore to ignore testsuite directories.