Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update icepack, copyright, version number #326

Merged
merged 1 commit into from
Jun 25, 2019

Conversation

apcraig
Copy link
Contributor

@apcraig apcraig commented Jun 20, 2019

PR checklist

  • Short (1 sentence) summary of your PR:
    Update Icepack, copyright date, and version number is prep for 6.0.1 release
  • Developer(s):
    apcraig
  • Suggest PR reviewers from list in the column to the right.
  • Please copy the PR test results link or provide a summary of testing completed below.
    #efdb29b4e2362f97d, https://github.com/CICE-Consortium/Test-Results/wiki/cice_by_hash_forks
  • How much do the PR code changes differ from the unmodified code?
    • bit for bit
    • different at roundoff level
    • more substantial
  • Does this PR create or have dependencies on Icepack or any other models?
    • Yes
    • No
      but only that it updates Icepack, there are no dependencies
  • Does this PR add any new test cases?
    • Yes
    • No
  • Is the documentation being updated? ("Documentation" includes information on the wiki or in the .rst files from doc/source/, which are used to create the online technical docs at https://readthedocs.org/projects/cice-consortium-cice/.)
    • Yes
    • No, does the documentation need to be updated at a later time?
      • Yes
      • No
  • Please provide any additional information or relevant details below:

Updated icepack to #efdb29b4e2362f97d == Icepack1.1.1
Changed Copyright date to 2019
Change CICE internal version number to 6.0.1

@apcraig apcraig requested review from eclare108213 and duvivier June 20, 2019 21:07
Copy link
Contributor

@duvivier duvivier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are there so many more places in CICE that we have to change the date compared to Icepack? In any case there are no issues here from my end.

@apcraig
Copy link
Contributor Author

apcraig commented Jun 21, 2019

I realized after the fact that I missed one Copyright date in Icepack. I don't plan to fix it in the Icepack tag, but will after. I agree that we might want to consider if there are ways to consolidate the Copyright text somehow so we can share a single "file" that is used both in the documents and in the source code. I will create an issue to look into that.

Copy link
Contributor

@eclare108213 eclare108213 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope you found all of these! I agree it would be good to somehow automate these by connecting them to a single source.

@apcraig apcraig merged commit a6b6c3c into CICE-Consortium:master Jun 25, 2019
@apcraig apcraig deleted the ipv111 branch August 17, 2022 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants